Conversation
There was a problem hiding this comment.
Pull request overview
Adds Vitest coverage support and introduces new unit tests to increase runtime coverage for the JavaScript SDK’s Catcher and validation utilities.
Changes:
- Added comprehensive tests for
Catcherbehavior (delivery, dedupe, context/user handling, global handlers, addons). - Added focused tests for
src/utils/validation.tshelpers. - Added a
test:coveragescript and the@vitest/coverage-v8dependency to enable coverage reporting.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| yarn.lock | Locks new coverage-related dependencies (notably @vitest/coverage-v8). |
| packages/javascript/package.json | Adds test:coverage and @vitest/coverage-v8 dev dependency. |
| packages/javascript/tests/utils/validation.test.ts | New tests for validation helpers. |
| packages/javascript/tests/catcher.test.ts | New tests covering Catcher end-to-end behavior using a mocked transport. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neSpecc
reviewed
Mar 3, 2026
FeironoX5
approved these changes
Mar 4, 2026
neSpecc
reviewed
Mar 4, 2026
neSpecc
reviewed
Mar 4, 2026
neSpecc
reviewed
Mar 4, 2026
neSpecc
reviewed
Mar 4, 2026
Member
neSpecc
left a comment
There was a problem hiding this comment.
I think we should also cover module/sanitizer.ts by tests since it is a critical feature.
Member
Author
Done. |
neSpecc
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covering with tests components in
@hawk.so/javascript:catcher.tsmodules/sanitizer.tsutils/validation.tsCoverage report: