Optimize auth.js: Replace Buffer.from(x).toString('base64') with btoa#1651
Open
maslowivan wants to merge 2 commits intocommercetools:masterfrom
Open
Optimize auth.js: Replace Buffer.from(x).toString('base64') with btoa#1651maslowivan wants to merge 2 commits intocommercetools:masterfrom
maslowivan wants to merge 2 commits intocommercetools:masterfrom
Conversation
IE10+ browsers support btoa function. Do we really need 50kb Buffer polyfill in the browser?
Contributor
Author
|
For ones who using it with Babel/Webpack and a browser, you can hack this using this way: import SdkAuth, { TokenProvider } from '@commercetools/sdk-auth/dist/sdk-auth.es';
if (typeof Buffer === 'undefined' && typeof window !== 'undefined') {
window.Buffer = {
from: s => ({ toString: m => m === 'base64' ? btoa(s) : m }),
byteLength: s => s.length,
};
} |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IE10+ browsers support btoa function. Do we really need 50kb Buffer polyfill in the browser?
With this pull request #1650 we can just get rid of the entire Buffer's polyfill
Todo
Typelabel for the PR