-
-
Notifications
You must be signed in to change notification settings - Fork 320
feat(bump): add --version-files-only and deprecate --files-only #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next-release
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next-release #1802 +/- ##
=============================================
Coverage 97.96% 97.96%
=============================================
Files 60 60
Lines 2651 2655 +4
=============================================
+ Hits 2597 2601 +4
Misses 54 54 ☔ View full report in Codecov by Sentry. |
cb94f8b to
b5e7cdb
Compare
b5e7cdb to
527c814
Compare
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits
| configuration file only. | ||
| configuration file only(deprecated; use --version- | ||
| files-only instead). | ||
| --version-files-only bump version in the files from the config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| --version-files-only bump version in the files from the config | |
| --version-files-only Bump version in the files from the config |
| { | ||
| "name": "--version-files-only", | ||
| "action": "store_true", | ||
| "help": "bump version in the files from the config", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "help": "bump version in the files from the config", | |
| "help": "Bump version in the files from the config", |
| with pytest.warns(DeprecationWarning): | ||
| with pytest.raises(ExpectedExit): | ||
| util.run_cli("bump", "--yes", "--files-only") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| with pytest.warns(DeprecationWarning): | |
| with pytest.raises(ExpectedExit): | |
| util.run_cli("bump", "--yes", "--files-only") | |
| with pytest.warns(DeprecationWarning), pytest.raises(ExpectedExit): | |
| util.run_cli("bump", "--yes", "--files-only") |
Rework of #1659. It was close to merge.
Closes #1658