test: enable ruff rule PT #1837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1837 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 60 60
Lines 2691 2691
=======================================
Hits 2637 2637
Misses 54 54 ☔ View full report in Codecov by Sentry. |
bearomorphism
changed the title
Lee-W
reviewed
Feb 4, 2026
tests/conftest.py
Outdated
| f"gpg --batch --yes --debug-quick-random --passphrase '' --quick-gen-key '{SIGNER} {SIGNER_MAIL}'" | ||
| ) | ||
| if c.return_code != 0: | ||
| raise Exception(f"gpg keygen failed with err: '{c.err}'") |
Member
There was a problem hiding this comment.
Suggested change
| raise Exception(f"gpg keygen failed with err: '{c.err}'") | |
| raise Exception(f"gpg keygen failed with err: '{c.err}'") | |
| raise subprocess.CalledProcessError( | |
| returncode=c.return_code, | |
| cmd="gpg --batch --yes --debug-quick-random --passphrase '' --quick-gen-key", | |
| stderr=c.err, | |
| ) |
or we can create an exception for it
Collaborator
Author
There was a problem hiding this comment.
Thanks!
(AI was used to assist generating this section)
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
It turns out that I just had to run uv run ruff check --fix --unsafe-fixes
bearomorphism
force-pushed
the
pytest-ruff
branch
from
98438a0 to
ddce169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that I just had to run uv run ruff check --fix --unsafe-fixes for PT006 and PT007