Update xeus-cpp to be compatible with xeus 6.0#453
Update xeus-cpp to be compatible with xeus 6.0#453mcbarton wants to merge 2 commits intocompiler-research:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 81.25% 81.06% -0.19%
==========================================
Files 21 21
Lines 864 866 +2
Branches 78 78
==========================================
Hits 702 702
- Misses 162 164 +2
🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I would have just waited for @JohanMabille to make this change cause he's the most educated about the update to xeus 6 😬 But yeah let's ask him to review this right now as you've already made it ! |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
The idea is also to always use helper functions to create the response messages instead of building them adhoc.
Also the kernelspec should be updated to contain the new field "kernel_protocol_version" and with value "5.6.0".
|
clang-tidy review says "All clean, LGTM! 👍" |
With the recent release of xeus 6.0 the ci for xeus-cpp is failing on main due to the breaking changes made to xeus.