Skip to content

Update xeus-cpp to be compatible with xeus 6.0#453

Open
mcbarton wants to merge 2 commits intocompiler-research:mainfrom
mcbarton:main
Open

Update xeus-cpp to be compatible with xeus 6.0#453
mcbarton wants to merge 2 commits intocompiler-research:mainfrom
mcbarton:main

Conversation

@mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Mar 6, 2026

With the recent release of xeus 6.0 the ci for xeus-cpp is failing on main due to the breaking changes made to xeus.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.06%. Comparing base (3002a8e) to head (c3f58d4).

Files with missing lines Patch % Lines
src/xinterpreter.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   81.25%   81.06%   -0.19%     
==========================================
  Files          21       21              
  Lines         864      866       +2     
  Branches       78       78              
==========================================
  Hits          702      702              
- Misses        162      164       +2     
Files with missing lines Coverage Δ
src/xinterpreter.cpp 89.50% <50.00%> (-1.12%) ⬇️
Files with missing lines Coverage Δ
src/xinterpreter.cpp 89.50% <50.00%> (-1.12%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

clang-tidy review says "All clean, LGTM! 👍"

@anutosh491
Copy link
Collaborator

anutosh491 commented Mar 6, 2026

I would have just waited for @JohanMabille to make this change cause he's the most educated about the update to xeus 6 😬

But yeah let's ask him to review this right now as you've already made it !

@mcbarton mcbarton requested a review from JohanMabille March 6, 2026 07:56
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is also to always use helper functions to create the response messages instead of building them adhoc.

Also the kernelspec should be updated to contain the new field "kernel_protocol_version" and with value "5.6.0".

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton requested a review from JohanMabille March 6, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants