[Clang] Fix crash in CheckNonTypeTemplateParameterType with invalid type#2
Open
sdkrystian wants to merge 1 commit intocppalliance:mainfrom
Open
[Clang] Fix crash in CheckNonTypeTemplateParameterType with invalid type#2sdkrystian wants to merge 1 commit intocppalliance:mainfrom
sdkrystian wants to merge 1 commit intocppalliance:mainfrom
Conversation
SubstAutoTypeSourceInfoDependent can return null when transforming an invalid type containing decltype(auto). Handle this case by returning QualType() to signal failure. Fixes llvm#177545
sdkrystian
force-pushed
the
fix-177545
branch
from
3c80346 to
0108771
Compare
shafik
reviewed
Jan 28, 2026
shafik
left a comment
shafik
left a comment
There was a problem hiding this comment.
Looks good but this need a release note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a non-type template parameter has a type containing an undeduced placeholder type that is invalid (e.g., a function returning a function),
SubstAutoTypeSourceInfoDependentcan return null if the type is invalid.CheckNonTypeTemplateParameterTypewas not handling this case and would dereference the null pointer.Fixes llvm#177545