[Clang][Sema] Fix crash when nested-name-specifier prefix points to non-dependent context#5
Open
sdkrystian wants to merge 1 commit intocppalliance:mainfrom
Open
[Clang][Sema] Fix crash when nested-name-specifier prefix points to non-dependent context#5sdkrystian wants to merge 1 commit intocppalliance:mainfrom
sdkrystian wants to merge 1 commit intocppalliance:mainfrom
Conversation
…on-dependent context
mizvekov
requested changes
Feb 5, 2026
| @@ -1,4 +1,5 @@ | |||
| // RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s | |||
Collaborator
There was a problem hiding this comment.
I'd just add -fms-extensions to the current test invocation, since it only enables extensions but doesn't change how existing code behaves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 154507c, a
NestedNameSpecifierofTypekind can have a prefix pointing to a non-dependent type even when the NNS itself is dependent. This occurs when theTypehas a prefix in its own qualified-id that refers to a non-dependent record.The
getCurrentInstantiationOf()function inSemaCXXScopeSpec.cppwould callisCurrentInstantiation()on such non-dependent records, triggering an assertion failure sinceisCurrentInstantiation()requires the record to be a dependent context.This patch adds a guard to check
isDependentContext()before callingisCurrentInstantiation(), matching the pattern used in all other call sites ofisCurrentInstantiation()throughout the codebase.Fixes 178324 in upstream.