Skip to content

Fix gd build on PHP 8.5#1043

Open
crazywhalecc wants to merge 2 commits intomainfrom
fix/gd-php85
Open

Fix gd build on PHP 8.5#1043
crazywhalecc wants to merge 2 commits intomainfrom
fix/gd-php85

Conversation

@crazywhalecc
Copy link
Owner

@crazywhalecc crazywhalecc commented Feb 25, 2026

What does this PR do?

PHP 8.5 has removed gd_pixelate.c, our patch needs update. (Copied from gd_config_81.w32).

Also this depends on #1041 .

We still need our own w32 because of static compilation.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

}

// zlib ext support (required)
if (!CHECK_LIB("zlib_a.lib;zlib.lib", "gd", PHP_GD)) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relates to #1041, where I mentioned that we were going to copy it anyway because the PHP code or other libraries might depend on the old name, so let's leave it at that.

@henderkes
Copy link
Collaborator

needs zlib fix first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants