Skip to content

fix ast slices#816

Merged
craigbarratt merged 1 commit intocustom-components:masterfrom
dmamelin:fix-ast-slice
Feb 22, 2026
Merged

fix ast slices#816
craigbarratt merged 1 commit intocustom-components:masterfrom
dmamelin:fix-ast-slice

Conversation

@dmamelin
Copy link
Contributor

Issue #809 caught my attention, and here's what I found:

ast.Slice indeed has no value attribute. Maybe it existed at some point and changed in ast.py, but it's more likely a copy/paste mistake from the ast_index function right above.

In most cases this didn't surface because recurse_assign, ast_delete, and ast_subscript have special handling for ast.Slice.

Didn't add numpy tests - slices are already well covered.

@craigbarratt craigbarratt merged commit 2ecddf4 into custom-components:master Feb 22, 2026
6 checks passed
@craigbarratt
Copy link
Member

Nice catch & fix - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants