Added 'git clean' and improved code comments#21
Open
moay wants to merge 3 commits intoczproject:masterfrom
Open
Added 'git clean' and improved code comments#21moay wants to merge 3 commits intoczproject:masterfrom
moay wants to merge 3 commits intoczproject:masterfrom
Conversation
janpecha
requested changes
Mar 1, 2018
Contributor
janpecha
left a comment
janpecha
left a comment
There was a problem hiding this comment.
Hi, thanks for PR. Currently I am on vacation, I will look at it later (in next week). For now I wrote some review comments.
| /** | ||
| * Clean repo. | ||
| * `git clean` | ||
| * @param bool $cleanDirectories |
Contributor
There was a problem hiding this comment.
Please remove $cleanDirectories part
| * @throws GitException | ||
| * @return self | ||
| */ | ||
| public function clean($cleanDirectories = true, $force = true) |
Contributor
There was a problem hiding this comment.
Change all true/false/null to uppercase TRUE/FALSE/NULL
| /** | ||
| * @param string | ||
| */ | ||
| /** |
Contributor
There was a problem hiding this comment.
Please fix indentation from spaces to tabs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added git clean to the repo functionality and fixed the Comments to have them declare the proper exception throwing. As both files are in the same namespace, the thrown error should be either
\Cz\Git\GitExceptionor justGitException, is chose the latter.