Skip to content

DAOS-18375 control: Set scm_hugepages_disabled default to true #17526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tanabarr wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DAOS-18375 control: Set scm_hugepages_disabled default to true #17526

tanabarr wants to merge 4 commits into from
+132 −52

Conversation

@tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Feb 8, 2026 •
edited
Loading

Set scm_hugepages_disabled to true in yaml unmarshal function before
unmarshalling so the default is true if unset in the config file.

Features: control

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@tanabarr
DAOS-18375 control: Set scm_hugepages_disabled default to true
f23588c 
Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr requested review from a team as code owners February 8, 2026 13:39
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

Ticket title is 'Set scm_hugepages_disabled default to true'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-18375

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 9, 2026

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/1/execution/node/1356/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 9, 2026

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/1/execution/node/1336/log

@tanabarr tanabarr self-assigned this Feb 9, 2026
@tanabarr tanabarr requested review from kjacque, knard38 and mjmac February 9, 2026 10:22
knard38
knard38 reviewed Feb 9, 2026
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding there is some minor fixes to be done.

utils/config/daos_server.yml Outdated
@@ -420,7 +420,8 @@
# # When class is set to ram, tmpfs will be mounted with hugepage
Copy link
Contributor

@knard38 knard38 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments associated to scm_hugepages_disabled should probably be updated as it will be mounted without huge page enabled by default from my understanding.

Copy link
Contributor Author

@tanabarr tanabarr Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/control/server/storage/config_test.go Outdated
`,
expResult: true,
},
// "explicitly set to false": {
Copy link
Contributor

@knard38 knard38 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove as it is tested in TestStorage_ScmConfig_DisableHugepages_MultipleEngines ?

Copy link
Contributor Author

@tanabarr tanabarr Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 9, 2026

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/2/execution/node/468/log

@tanabarr
address review comments
d690650 
Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr
Merge remote-tracking branch 'origin/master' into tanabarr/control-sc…
dc7107f 
…mhuge-disabled-default

Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr requested a review from knard38 February 10, 2026 12:29
knard38
knard38 previously approved these changes Feb 10, 2026
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanabarr
bump pool test_create_no_space_loop Timeout
e6a2777 
Features: pool
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr requested review from a team as code owners February 10, 2026 14:58
daltonbohning
daltonbohning reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 11, 2026

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/5/execution/node/1088/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 11, 2026

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/6/execution/node/449/log

kjacque
kjacque reviewed Feb 11, 2026
View reviewed changes
src/control/server/config/server_test.go

// Config A written from uncommented file with scm_hugepages_disabled: false
// set explicitly whereas when config B yaml gets written,
// scm_hugepages_disabled is omitted (omitempty) and therefore when read is
Copy link
Contributor

@kjacque kjacque Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If true is the default, isn't omitempty no longer correct? Since empty == false == non-default. Maybe I'm missing something here.

Copy link
Contributor Author

@tanabarr tanabarr Feb 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit tricky. Without "omitempty", each storage tier will output scm_hugepages_disabled: false on unmarshal regardless as to whether it's SCM type or not. This as a result of in-lining both ScmConfig and BdevConfig types into the TierConfig struct. The lessor of two evils IMO is to hack this test into understanding the asymmetry.

Copy link
Contributor

@kjacque kjacque Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Yeah that's a bit ugly. That makes me a bit concerned about any other strange incongruities, though. Is this a switch people can flip in the autoconfig flow? If so wouldn't omitempty cause a problem for the case users are actually trying to address?

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 11, 2026

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/7/execution/node/687/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 12, 2026

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/7/execution/node/803/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 12, 2026

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/8/execution/node/468/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 12, 2026

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17526/8/testReport/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjacque kjacque kjacque left review comments

@knard38 knard38 knard38 approved these changes

@mjmac mjmac Awaiting requested review from mjmac

@daltonbohning daltonbohning Awaiting requested review from daltonbohning

At least 2 approving reviews are required to merge this pull request.

Assignees

@tanabarr tanabarr

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tanabarr @daosbuild3 @daltonbohning @kjacque @knard38