Skip to content

Conversation

@jolivier23
Copy link
Contributor

On Google debian based system, DAOS doesn't compile.

  • Macro string is 17 characters because C already adds the nil
  • true; is a noop

Change-Id: I1a563aa6ee0d2d50eece429721bd4e08961d63b1

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

On Google debian based system, DAOS doesn't compile.

* Macro string is 17 characters because C already adds the nil
* true; is a noop

Change-Id: I1a563aa6ee0d2d50eece429721bd4e08961d63b1
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 requested review from a team as code owners February 9, 2026 15:53
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Ticket title is 'Generic ticket for minor code cleanup and improvement'
Status is 'Resolved'
Labels: 'request_for_2.6.5,request_for_2.6.6,scrubbed_2.6.5'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-623

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Feb 9, 2026
@@ -1,2 +1,2 @@
/* SPDX-License-Identifier: BSD-3-Clause */
/* Copyright 2015-2020, Intel Corporation */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the copyright script is not working for these files @daltonbohning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because the Intel format is different than expected, so the script doesn't pick it up. Could you manually add a copyright for this one?

Copy link
Contributor

@daltonbohning daltonbohning Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And/or also fix the intel format to

/* Copyright 2015-2020 Intel Corporation. */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority Ticket has high priority (automatically managed)

Development

Successfully merging this pull request may close these issues.

3 participants