DAOS-16964 ddb: read-only mode requires enabling Copy-on-Write for... #17533
+35
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EMOBJ pools PMEMOBJ maintains its own metadata. Copy-on-Write prevents these changes from taking effect so read-only mode will be truly read-only. Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Ticket title is 'Opening a VOS file in read only mode with DDB is not safe' |
Nasf-Fan
approved these changes
Feb 10, 2026
Contributor
|
LGTM. This patch was manually tested and the vos file are indeed not updated any more when opened in read only. Without this patch, the md5sum is not the same with the same use case. |
grom72
reviewed
Feb 10, 2026
| /* Open and close a pool for a ddb_ctx */ | ||
| int | ||
| dv_pool_open(const char *path, const char *db_path, daos_handle_t *poh, uint32_t flags); | ||
| dv_pool_open(const char *path, const char *db_path, daos_handle_t *poh, uint32_t flags, bool cow); |
Contributor
There was a problem hiding this comment.
What does "cow" mean?
dv_pool_open(const char *path, const char *db_path, daos_handle_t *poh, uint32_t flags, bool read_only);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... PMEMOBJ pools
PMEMOBJ maintains its own metadata. Copy-on-Write prevents these changes from taking effect so read-only mode will be truly read-only.
Steps for the author:
After all prior steps are complete: