DAOS-18483 test: fix OSAOfflineReintegration #17534
Conversation
|
Ticket title is 'osa/offline_reintegration.py:OSAOfflineReintegration.test_osa_offline_reintegrate_during_rebuild - False is not true : Pool Version Error: After exclude' |
Some rank exclusions were hardcoded to the wrong rank. Test-tag: OSAOfflineReintegration Test-repeat: 3 Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
daltonbohning
force-pushed
the
dbohning/daos-18483
branch
from
70f29fe to
e0268da
Compare
rpadma2
left a comment
rpadma2
left a comment
There was a problem hiding this comment.
If you have any questions, please let me know.
| if (self.test_during_rebuild is True and index == 0): | ||
| # Exclude rank 5 | ||
| output = self.pool.exclude("5") | ||
| # Exclude the rank |
There was a problem hiding this comment.
Looks like we are breaking the intention of the code here (exclusion of a rank during rebuild).
Start a rebuild operation by excluding a rank... Previous code picked rank "5". I would recommend to pick any rank on line number 99. It is fine. But, line number 113, should use a different rank.
The present change will exclude the same rank twice where the second exclude is just a NOP.
Based on my present data corruption testing, we should add a pool query after line 99 and wait for "Rebuild Busy" state and then allow the exclusion of another rank on line number 113.
There was a problem hiding this comment.
I updated to exclude a different rank but TBH I don't really follow the logic of this function
3 participants
Some rank exclusions were hardcoded to the wrong rank.
Test-tag: OSAOfflineReintegration
Test-repeat: 3
Skip-unit-tests: true
Skip-fault-injection-test: true
Steps for the author:
After all prior steps are complete: