Skip to content

ENH: test binops with float_array, int_scalar combinations#410

Merged
ev-br merged 2 commits intodata-apis:masterfrom
ev-br:scalars_stragegy
Jan 30, 2026
Merged

ENH: test binops with float_array, int_scalar combinations#410
ev-br merged 2 commits intodata-apis:masterfrom
ev-br:scalars_stragegy

Conversation

@ev-br
Copy link
Member

@ev-br ev-br commented Jan 17, 2026

Previously, we only tested the matching type/dtype combinations, i.e.

  • float_array, float_scalar
  • int_array, int_scalar
  • bool_array, bool_scalar

So float_array, int_scalar combinations were missing (cross-ref #364)

Tested locally with 10_000 examples on array_api_strict, numpy, cupy, torch and jax, and 1000 examples on dask. No new failures.

TODO

@ev-br
Copy link
Member Author

ev-br commented Jan 17, 2026

Updated test_clip. Caught a failure on JAX with

E           ========== FAILING CODE SNIPPET:
E           xp.clip(Array(0, dtype=uint64), **kw) with kw = {'min': 0, 'max': 9223372036854775808}
E           ====================

Reported upstream at jax-ml/jax#34455

@ev-br
Copy link
Member Author

ev-br commented Jan 21, 2026

Converting to draft until 2025.12 is out because clip update allowing min, max to be python scalars is new in 2025.12

ev-br added 2 commits January 30, 2026 17:03
Get rid of ad hoc mM and positive arguments. Use the same
`min_value`, `max_value` kwargs for scalars and arrays of varying
types/dtypes.
Previously, we only tested the matching type/dtype combinations, i.e.
- float_array, float_scalar
- int_array, int_scalar
- bool_array, bool_scalar
@ev-br ev-br marked this pull request as ready for review January 30, 2026 16:08
@ev-br ev-br merged commit 0580097 into data-apis:master Jan 30, 2026
5 checks passed
@ev-br
Copy link
Member Author

ev-br commented Jan 30, 2026

clip and searchorted updates are 2025.12 material, will be handled separately. The rest is better coverage of 2024.12, did not seem to cause new failures locally, so it's in. Post-merge reviews are welcome, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant