ENH: test binops with float_array, int_scalar combinations#410
Merged
ev-br merged 2 commits intodata-apis:masterfrom Jan 30, 2026
Merged
ENH: test binops with float_array, int_scalar combinations#410ev-br merged 2 commits intodata-apis:masterfrom
float_array, int_scalar combinations#410ev-br merged 2 commits intodata-apis:masterfrom
Conversation
This was referenced Jan 17, 2026
Member
Author
|
Updated Reported upstream at jax-ml/jax#34455 |
Member
Author
|
Converting to draft until 2025.12 is out because |
Get rid of ad hoc mM and positive arguments. Use the same `min_value`, `max_value` kwargs for scalars and arrays of varying types/dtypes.
Previously, we only tested the matching type/dtype combinations, i.e. - float_array, float_scalar - int_array, int_scalar - bool_array, bool_scalar
c435e4b to
05e89f3
Compare
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we only tested the matching type/dtype combinations, i.e.
So
float_array, int_scalarcombinations were missing (cross-ref #364)Tested locally with
10_000examples onarray_api_strict,numpy,cupy,torchandjax, and1000examples ondask. No new failures.TODO
clipfloat array, int min/max -- in Testclip-ing of a float array with integer scalarsmin/max#411searchsorted-- in WIP: searchsorted: allowx2to be python scalar #394