Fix nullable fields handling with JSON source #58
Fix nullable fields handling with JSON source #58VictorD-Veolia wants to merge 3 commits intodata-integrations:developfrom
Conversation
|
@VictorD-Veolia do you mind sharing the exact issue (some sample response for which the plugin failed before the fix)? If you can add a test to demonstrate it, that would be even better. |
|
Also, since this repository does not have automatic builds set up yet, would it be possible to paste the output of |
|
Hi @bdmogal, I added a unit test and created an issue in JIRA : https://cdap.atlassian.net/browse/PLUGIN-805 I also added to this comment the output of the |
pom.xml
Outdated
| <hadoop.version>2.3.0</hadoop.version> | ||
| <httpcomponents.version>4.5.9</httpcomponents.version> | ||
| <hydrator.version>2.4.0-SNAPSHOT</hydrator.version> | ||
| <hydrator.version>2.4.0</hydrator.version> |
There was a problem hiding this comment.
We should bump to a release version in the develop branch
| @@ -0,0 +1,109 @@ | |||
| /* | |||
| * Copyright © 2019-2020 Cask Data, Inc. | |||
rmstar
left a comment
rmstar
left a comment
There was a problem hiding this comment.
please squash commits after addressing comment
| <hadoop.version>2.3.0</hadoop.version> | ||
| <httpcomponents.version>4.5.9</httpcomponents.version> | ||
| <hydrator.version>2.4.0-SNAPSHOT</hydrator.version> | ||
| <hydrator.version>2.10.0-SNAPSHOT</hydrator.version> |
There was a problem hiding this comment.
This should be set to a non-snapshot version
4 participants
Fix an error in JSONPage that prevented HTTP sources to handle nullable fields correctly.