feat(appkit): introduce Lakebase Autoscaling driver#98
Open
pkosiec wants to merge 4 commits intopkosiec/lakebase-v2-driver-1from
Open
feat(appkit): introduce Lakebase Autoscaling driver#98pkosiec wants to merge 4 commits intopkosiec/lakebase-v2-driver-1from
pkosiec wants to merge 4 commits intopkosiec/lakebase-v2-driver-1from
Conversation
pkosiec
changed the title
pkosiec
force-pushed
the
pkosiec/lakebase-v2-driver-2
branch
from
562a2c7 to
eef0969
Compare
| const userConfig = config ?? {}; | ||
|
|
||
| // Initialize telemetry once and thread it through to avoid duplicate instruments | ||
| const telemetry = initTelemetry(userConfig); |
Collaborator
There was a problem hiding this comment.
if we are planning to ship this connector as a separate package, how are you planning on decoupling the logger and the telemetry provider from this? because as it is we can't really make it a separate package no?
Collaborator
|
code in general looks good, but I did run the tests and there are a lot failing 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intro
Works with Lakebase Autoscaling
Supports OAuth authentication and automatic token refresh
WorkspaceClientfromdatabricks-sdk-jsfor authentication (client credentials flow / reusing existingDATABRICKS_TOKEN)generate_database_credential: https://github.com/databricks/databricks-sdk-py/blob/a0b75908723f874fbf1659962df49ad57d3afe6a/databricks/sdk/service/postgres.py#L1808It’s a wrapper over the
pg.Pool: it means it works with any PostgreSQL databaseCompatible with popular TypeScript/JavaScript ORMs
Implementation aligned with Theo's Apps Runtime design doc
Related document
https://docs.google.com/document/d/13WTwiqCmfDlxzBRs6uOlGBtJ3f0qENw4uakK4cfkbg8/edit?tab=t.0
https://databricks.atlassian.net/browse/LKB-9058