chore: add Lakebase Autoscaling example for dev-playground app#99
Open
pkosiec wants to merge 3 commits intopkosiec/lakebase-v2-driver-2from
Open
chore: add Lakebase Autoscaling example for dev-playground app#99pkosiec wants to merge 3 commits intopkosiec/lakebase-v2-driver-2from
dev-playground app#99pkosiec wants to merge 3 commits intopkosiec/lakebase-v2-driver-2from
Conversation
pkosiec
force-pushed
the
pkosiec/lakebase-v2-3
branch
2 times, most recently
from
3e79a1e to
03f3812
Compare
pkosiec
force-pushed
the
pkosiec/lakebase-v2-3
branch
from
76089ef to
dfe38e6
Compare
Comment on lines
+9
to
+10
| "experimentalDecorators": true, | ||
| "emitDecoratorMetadata": true, |
Collaborator
There was a problem hiding this comment.
please don't 🤣 where are we using decorators? let's not add them please 😄
Collaborator
There was a problem hiding this comment.
yeah just saw why, please move this into the dev-playground tsconfig.json, I would like to avoid having decorators in appkit 🙏🏻
| return; | ||
| } | ||
|
|
||
| // Register routes for each example under /api/lakebaseExamples/* |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Register routes for each example under /api/lakebaseExamples/* | |
| // Register routes for each example under /api/lakebase-examples/* |
| @@ -0,0 +1,15 @@ | |||
| import { defineConfig } from "tsdown"; | |||
Collaborator
There was a problem hiding this comment.
why do we need this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the PoC testing scenarios for instructions how to test it.
https://databricks.atlassian.net/browse/LKB-9058
Screenshots