Closed
Conversation
Update the CLI dependency and checksums so this branch validates against the latest SDK release. Co-authored-by: Cursor <cursoragent@cursor.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 2dca3db
15 interesting tests: 8 RECOVERED, 7 SKIP
Top 20 slowest tests (at least 2 minutes):
|
simonfaltum
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Move the CLI SDK dependency from v0.109.0 to v0.110.0 and refresh module checksums accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Update the OpenAPI SHA and regenerate schema annotations/jsonschema for new SDK fields, and extend postgres direct-resource known remote gaps for newly added flattened project fields. Co-authored-by: Cursor <cursoragent@cursor.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Address new SDK field/lint fallout by updating external location and postgres project struct literals, suppressing legacy quality monitor API deprecation warnings, and syncing acceptance refschema and Python bundle codegen outputs. Co-authored-by: Cursor <cursoragent@cursor.com>
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Feb 19, 2026
| } | ||
|
|
||
| func (s *QualityMonitor) Exists(ctx context.Context, w *databricks.WorkspaceClient, id string) (bool, error) { | ||
| //nolint:staticcheck // Bundle resource still uses legacy QualityMonitors API until direct migration is complete. |
Member
Author
There was a problem hiding this comment.
In SDK v0.110.0, the catalog.QualityMonitors.* methods were marked deprecated in Go doc comments and staticcheck treats calls to deprecated APIs as SA1019
seems like the code here still calls those methods (e.g. Get/Create/Update/Delete) because it hasn’t been migrated to the newer Data Quality API path yet
effectively after the SDK bump, CI started failing on lint even though runtime behavior remained the same
Contributor
There was a problem hiding this comment.
This should be empty, I think?
"Effective" fields are output only, so shouldn't be passed in the update payload.
Contributor
There was a problem hiding this comment.
Yes, correct, we should leave them empty
Member
Author
There was a problem hiding this comment.
SDK v0.110.0 added EffectiveEnableFileEvents to both catalog.CreateExternalLocation and catalog.UpdateExternalLocation
Our exhaustruct lint requires every field in struct literals to be explicitly set, so adding it was the fastest way to make lint pass
But idk if because we reuse CreateExternalLocation as state, setting this output-only field from remote (info.EffectiveEnableFileEvents) can flow into update config later
Contributor
There was a problem hiding this comment.
I suspect you ran generation with the private version of the spec, not the public one.
Member
Author
There was a problem hiding this comment.
I did make .codegen/openapi.json and DATABRICKS_OPENAPI_SPEC=.codegen/openapi.json make schema
Not sure if that is wrong?
renaudhartert-db
approved these changes
Feb 19, 2026
This reverts commit 2dca3db.
This reverts commit b48d33d.
Revert the prior manual regeneration path and regenerate from the canonical `make generate` flow for SDK v0.110.0, then apply minimal follow-up fixes for lint/schema/refschema parity and generated Python artifacts. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
Closing this SDK bump PR as it will not be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
github.com/databricks/databricks-sdk-gofromv0.106.0tov0.110.0.make generateflow (genkit update-sdk + post-generate steps)..codegen/_openapi_shato match the OpenAPI SHA used by SDKv0.110.0.annotations*.yml,bundle/schema/jsonschema.json, andbundle/schema/jsonschema_for_docs.json) for new SDK/OpenAPI fields.knownMissingInRemoteTypeentries for flattenedpostgres_projectsfields (budget_policy_id,custom_tags).effective_*field explicit but empty in state/update payload mappings.//nolint:staticcheckcomments for legacy Quality Monitors API usage.acceptance/bundle/refschema/out.fields.txtjobs.SparseCheckoutmodel.Why
Keep CLI generated assets and typed resource mappings in sync with the upgraded SDK/OpenAPI version so schema/build/lint/acceptance/codegen checks pass.
Terraform alignment note
The CLI currently pins Terraform provider
v1.106.0, which depends ondatabricks-sdk-go v0.106.0.The latest released provider (
v1.107.0) depends ondatabricks-sdk-go v0.108.0.So exact Terraform/CLI SDK alignment to
v0.110.0is not available yet via a released provider and will be done in a follow-up bump.Tests
make generate./tools/golangci-lint rungo test ./internal/build ./bundle/internal/schema ./bundle/direct/dresources ./bundle/config/resources -count=1go test ./acceptance -run '^TestAccept/bundle/refschema$' -update -timeout=30m(2 passes)go test ./acceptance -run '^TestAccept/bundle/refschema$' -timeout=30mpushd python && make codegen && popd