SSH: better validation for "ssh connect" options#4623
Merged
Conversation
- Add validation for connection name to ensure it only contains letters, numbers, dashes, and underscores - Add validation for IDE value to ensure it is either "vscode" or "cursor" - Move existing and new validation logic to the ClientOptions level - Add tests for ClientOptions Validate and ToProxyCommand
ilia-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Collaborator
|
Commit: 1e5764f
15 interesting tests: 7 KNOWN, 7 SKIP, 1 RECOVERED
Top 34 slowest tests (at least 2 minutes):
|
anton-107
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
We didn't have validation for the --name flag, and --ide validation was too late in the process
Tests
New unit tests