Prevent SliderDots from demanding children it doesn't use in Typescript#24
Open
Violettica wants to merge 1 commit intodavedbase:mainfrom
Open
Prevent SliderDots from demanding children it doesn't use in Typescript#24Violettica wants to merge 1 commit intodavedbase:mainfrom
Violettica wants to merge 1 commit intodavedbase:mainfrom
Conversation
SliderDots used the FlowComponent type, which is meant for components that strictly require children to function. SliderDots does not appear to use props.children anywhere, therefore it is more appropriate to use the Component type instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SliderDotsused theFlowComponenttype, which is meant for components that strictly require children to function.SliderDotsdoes not appear to useprops.childrenanywhere, therefore it is more appropriate to use the Component type instead.