Skip to content

Remove vim exit sequence, which has no effect#1546

Merged
rolandwalker merged 1 commit intomainfrom
RW/remove-vim-exit-sequence
Feb 16, 2026
Merged

Remove vim exit sequence, which has no effect#1546
rolandwalker merged 1 commit intomainfrom
RW/remove-vim-exit-sequence

Conversation

@rolandwalker
Copy link
Contributor

Description

I've tried to figure this out, but the multiline exception for :q seems to have no effect. Maybe it was an in-joke?

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Feb 14, 2026
Copy link
Contributor

@scottnemes scottnemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I researched python REPL as I'd never heard of it, but as best I can tell :q isn't a thing there as it is in actual vim so doesn't seem to be useful here.

@rolandwalker rolandwalker force-pushed the RW/remove-vim-exit-sequence branch from 3f4abc9 to be50439 Compare February 16, 2026 08:47
@github-actions
Copy link

No correctness, security, or regression issues found in the changes.

Notes

  • There’s no test coverage around _multiline_exception() behavior. If you want to guard against future regressions, consider adding a small unit test in test to assert that only actual special commands (e.g., \q, exit, quit) bypass multiline, and :q does not.

Tests not run (not requested).

@rolandwalker rolandwalker merged commit 4228c0f into main Feb 16, 2026
10 checks passed
@rolandwalker rolandwalker deleted the RW/remove-vim-exit-sequence branch February 16, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants