Use prompt_toolkit's complete_in_thread option#1548
Conversation
scottnemes
left a comment
There was a problem hiding this comment.
Nice, seems a little more snappy
|
@scottnemes the difference is most noticeable on a very long statement, since we are parsing the SQL to produce the completions. |
which makes the interface more responsive by not blocking typing.
4e74c41 to
b96732d
Compare
|
Review summary: Small change, but it alters threading behavior in completions. I see two correctness risks that should be addressed before merge.
Tests: I didn’t run tests. There’s no test coverage for threaded completion behavior; consider adding at least a concurrency smoke test around If you want, I can draft the locking wrapper or the version-guard patch. |
Description
This makes the interface more responsive by not blocking typing.
This is intended to combine with #1547 for more fluid typing.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).