Skip to content

Exclude more documentation files from CI#1559

Merged
rolandwalker merged 1 commit intomainfrom
RW/exclude-more-docs-from-ci
Feb 16, 2026
Merged

Exclude more documentation files from CI#1559
rolandwalker merged 1 commit intomainfrom
RW/exclude-more-docs-from-ci

Conversation

@rolandwalker
Copy link
Contributor

Description

Since #1556 needlessly ran the test suite.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Feb 14, 2026
@rolandwalker rolandwalker force-pushed the RW/exclude-more-docs-from-ci branch from 1bcabde to 132f4dc Compare February 16, 2026 08:39
@github-actions
Copy link

Findings

  1. CI can be skipped for test data changes
    Adding **.txt to paths-ignore will skip CI when .txt test fixtures change. This repo has .txt files under tests, so changes that can affect behavior won’t trigger CI. Example fixtures: test/features/fixture_data/help_commands.txt, test/features/fixture_data/help.txt, test/test.txt.
    Action: Narrow the ignore patterns to documentation-only paths (e.g. doc/**/*.txt, **/LICENSE.txt) or explicitly allow test paths. This change applies to all three workflows.
    Files: .github/workflows/ci.yml:6-8 (same change in .github/workflows/lint.yml and .github/workflows/typecheck.yml).

No other correctness or security concerns found.

Next steps

  1. Tighten the paths-ignore patterns to exclude only documentation .txt/.rst, not test fixtures.
  2. If you want, I can propose exact glob patterns based on your doc layout.

@rolandwalker rolandwalker force-pushed the RW/exclude-more-docs-from-ci branch from 132f4dc to 85e0549 Compare February 16, 2026 08:45
@github-actions
Copy link

No findings.

These changes only expand paths-ignore in workflow triggers. I don’t see correctness, security, or test gaps introduced by this PR.

If you want an extra safety net, consider whether any documentation-only changes should still trigger CI (e.g., docs-related build checks), but that’s a policy choice rather than a bug.

@rolandwalker rolandwalker force-pushed the RW/exclude-more-docs-from-ci branch from 85e0549 to d4eb542 Compare February 16, 2026 10:01
@github-actions
Copy link

No blocking issues found in the PR.

Notes

  1. paths-ignore only excludes doc/**/*.txt and doc/**/*.rst plus a few root docs. If the intent is to skip CI for other doc assets (e.g., doc/**/*.png, doc/**/*.svg, or screenshots/**), consider adding those patterns too.

Tests

  1. Not applicable for workflow-only changes.

If you want, I can suggest a fuller ignore list based on the current repo doc assets.

@rolandwalker rolandwalker merged commit bd8ae11 into main Feb 16, 2026
10 checks passed
@rolandwalker rolandwalker deleted the RW/exclude-more-docs-from-ci branch February 16, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants