Skip to content

Add DISTINCT to value-position keywords#1671

Merged
rolandwalker merged 1 commit intomainfrom
RW/distinct-value-position-keyword
Mar 3, 2026
Merged

Add DISTINCT to value-position keywords#1671
rolandwalker merged 1 commit intomainfrom
RW/distinct-value-position-keyword

Conversation

@rolandwalker
Copy link
Contributor

Description

Major omission. Covered under the existing changelog.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

  1. Low: Missing regression test for the new completion behavior
    • Change adds DISTINCT to pygments_value_position_nonfunction_keywords in mycli/sqlcompleter.py:839, but there is no test that validates SQLCompleter now actually offers DISTINCT in value-position/function-style completion contexts.
    • Existing DISTINCT coverage in test/test_completion_engine.py:178 only checks parser suggestion type (suggest_type), not final completion output.
    • Action: add a completer-level test (likely in test/test_smart_completion_public_schema_only.py or test/test_naive_completion.py) asserting DISTINCT appears in completions for a SELECT ... value-position scenario.

No correctness bug or security issue stood out in the one-line code change itself.

Note: I couldn’t run tests in this environment because pytest is not installed (pytest: command not found).

@rolandwalker rolandwalker force-pushed the RW/distinct-value-position-keyword branch from 64a26da to 5b635d8 Compare March 3, 2026 21:00
@rolandwalker rolandwalker force-pushed the RW/distinct-value-position-keyword branch from 5b635d8 to cbccccb Compare March 3, 2026 21:08
@rolandwalker rolandwalker merged commit 378cb6b into main Mar 3, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/distinct-value-position-keyword branch March 3, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants