Reproduction case for many clips freezing issue#87
Open
remorses wants to merge 5 commits intodiffusionstudio:mainfrom
Open
Reproduction case for many clips freezing issue#87remorses wants to merge 5 commits intodiffusionstudio:mainfrom
remorses wants to merge 5 commits intodiffusionstudio:mainfrom
Conversation
- Change imports from core-v4 to core in all playground files - Replace single animated video clip with multiple clips using sequential layer - Split 20-second video into 50 clips with 4-second minimum duration each - Use sliding window approach where clips overlap to maintain minimum duration - Skip clips that would exceed video duration - This setup helps reproduce browser hanging issue when adding many clips
- Remove all layers except video clips layer - Remove unused sources (images, audio, captions) - Remove font loading - Keep only the essential code for reproducing many clips issue - Composition now only contains 50 video clips of 4 seconds each
- Set CLIPS to 40 and minClipDuration to 3 - This configuration reliably reproduces the freeze after ~4 seconds of playback
There was a problem hiding this comment.
Pull request overview
This PR creates a minimal reproduction case for issue #86 where having many clips (more than 30) in a composition causes the player to freeze during playback. The changes simplify the playground example by removing all non-essential elements and creating 40 overlapping video clips from a single source using a sliding window approach.
Key Changes:
- Changed package dependency from
@diffusionstudio/core-v4to@diffusionstudio/core - Simplified composition to only include 40 video clips with 3-second duration each, created using a sliding window pattern
- Removed all other layers, effects, and animations to isolate the freezing issue
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| playground/composition.ts | Replaced complex multi-layer composition with simplified reproduction case creating 40 overlapping video clips |
| playground/timeline.ts | Updated import statement to use new package name |
| playground/render.ts | Updated import statement to use new package name |
| playground/main.ts | Updated import statement to use new package name |
| playground/controls.ts | Updated import statement to use new package name |
| package-lock.json | Updated package dependency from @diffusionstudio/core-v4 to @diffusionstudio/core with version 4.0.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a minimal reproduction case for the issue where having many clips (more than 30) in a composition causes the player to freeze during playback.
Changes
How to Reproduce
Related Issue
This reproduction case demonstrates the issue described in #86
Notes
The freeze happens consistently when there are many clips in the composition, regardless of the video duration. The timing of the freeze is inversely related to the number of clips - more clips cause the freeze to occur sooner.