feat: Add environment variable expansion for docker config plugin dirs#6487
Conversation
1759e72 to
d91b9d5
Compare
|
Hi @vvoland, any updates on this? |
f9717ab to
c3326fd
Compare
|
LGTM after squashing commits |
|
I'm slightly on the fence; wondering; does the (for the example) The point here is that we don't to env-var expansion for any of the other paths, so this may now become a sliding slope where it needs to be added to every path that's in config; the |
In general the
Feel free to tell me about the option names / code files and I will have a look whether I can implement it for the additional options |
…gins/manager/manager.go` test: Add test for plugin directory environment variable expansion Signed-off-by: Paulchen <lukas.23022005@gmail.com>
c3326fd to
da71a33
Compare
done 👍 |
|
Hey @vvoland are the changes fine and is it fine when I ping you? I don't wanna annoy you 😅 |
- What I did
Closes #6486
- How I did it
- How to verify it
- Human readable description for the release notes
Add support to expand environment variables in docker plugin config directory string
- Add support to expand environment variables in docker plugin config directory stringI am really really new to Go like
0.5%experience. The test is mainly assisted by Copilot with a bit of brain usage by my side. Feel free to help me to add like a negative test or something like that if the current one is not enough- A picture of a cute animal (not mandatory but encouraged)
