Draft
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dvdksn
force-pushed
the
reusable-workflow
branch
4 times, most recently
from
64d83ee to
4d36da3
Compare
dvdksn
force-pushed
the
reusable-workflow
branch
from
4d36da3 to
d80ccdb
Compare
dvdksn
force-pushed
the
reusable-workflow
branch
9 times, most recently
from
15ce257 to
c5a6cdb
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
reusable-workflow
branch
from
c5a6cdb to
13e9e4e
Compare
dvdksn
commented
Dec 3, 2025
| target = "aws-cloudfront-update" | ||
| contexts = { | ||
| sitedir = DOCS_SITE_DIR | ||
| sitedir = "target:release" |
Contributor
Author
There was a problem hiding this comment.
@crazy-max ptal at this. Not sure if this is something we should support.
The aws-cloudfront-update target was preceded by a release build:
The sitedir arg was used to bind mount the public directory into the build, from the local context:
So I changed the sitedir per above, to bind mount the build results from the release stage directly. But that doesn't work with the reusable workflow since we only allow building a single target at once:
https://github.com/docker/docs/actions/runs/19897113629/job/57030322616?pr=23745#step:4:184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.