HTTP routing with Traefik: Update guide to include DHI#23769
HTTP routing with Traefik: Update guide to include DHI#23769jarqvi wants to merge 6 commits intodocker:mainfrom
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks @jarqvi. Sorry, we had to quietly pause all reviews/changes for the surprise DHI free updates. Can you help update this based on that? |
|
It’s done; I made some changes in this regard. |
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
Thanks @jarqvi.
For the linter, any content/lines in between ordered steps needs to be indented. Otherwise lgtm.
For example:
1. Run this command:
`some command`
Then xyz will happen.
2. Run this other command:
`abc`
3. ...
| ``` | ||
|
|
||
| For example — use: | ||
| `FROM dhi.io/traefik:<tag>` |
There was a problem hiding this comment.
This Dockerfile snippet seems out of place. Not sure if it's a typo that was suppose to show a docker pull command, or it needs more context like, this guide shows you how to run the container, but you can also use it as a base image in a Dockerfile. For example...
| ```console | ||
| $ docker run -d --network=traefik-demo -p 80:80 -v /var/run/docker.sock:/var/run/docker.sock traefik:v3.6.2 --providers.docker | ||
| ``` | ||
| {{< tabs >}} |
There was a problem hiding this comment.
All the content between steps 2 to 3 should be indented.
| ```console | ||
| $ docker run -d --network=traefik-demo --label 'traefik.http.routers.nginx.rule=Host(`nginx.localhost`)' nginx | ||
| ``` | ||
| {{< tabs >}} |
There was a problem hiding this comment.
The whole section between steps 3 to 4 should be indented.
|
|
||
| Let’s do a quick demo of starting Traefik and then configuring two additional containers to be accessible using different hostnames. | ||
|
|
||
| <!-- markdownlint-disable MD029 --> |
There was a problem hiding this comment.
Suggest not disabling this. The errors are probably related to indention in the ordered list. Content between steps should be indented. In this particular case, between 2-3 and 3-4, you can add a couple spaces before all lines.
|
|
||
| Once the container starts, open your browser to http://welcome.localhost. You should see a “Welcome to Docker” website. | ||
|
|
||
| <!-- markdownlint-enable MD029 --> |
There was a problem hiding this comment.
As noted above, can remove disabling this after fixing the indentation.
|
|
||
| The application can be accessed on GitHub at [dockersamples/easy-http-routing-with-traefik](https://github.com/dockersamples/easy-http-routing-with-traefik). | ||
|
|
||
| <!-- markdownlint-disable MD029 --> |
There was a problem hiding this comment.
As noted above, can remove disabling this after fixing the indentation.
| volumes: | ||
| - /var/run/docker.sock:/var/run/docker.sock | ||
| ``` | ||
| {{< tabs >}} |
There was a problem hiding this comment.
The whole section between steps 1 to 2 should be indented.
| labels: | ||
| traefik.http.routers.client.rule: "Host(`localhost`)" | ||
| ``` | ||
| {{< tabs >}} |
There was a problem hiding this comment.
The whole section between steps 2 to 3 should be indented.
|
|
||
| And that’s it. Now, you only need to spin up the Compose stack with a `docker compose up` and all of the services and applications will be ready for development. | ||
|
|
||
| <!-- markdownlint-enable MD029 --> |
There was a problem hiding this comment.
As noted above, can remove disabling this after fixing the indentation.
2 participants
Description
Related issues or tickets
Reviews