Skip to content

trusktr testing (IGNORE THIS)#1414

Draft
trusktr wants to merge 1 commit intodevelopfrom
trusktr-testing
Draft

trusktr testing (IGNORE THIS)#1414
trusktr wants to merge 1 commit intodevelopfrom
trusktr-testing

Conversation

@trusktr
Copy link
Member

@trusktr trusktr commented Nov 1, 2020 •
edited
Loading

Just a PR I'm using for running tests.

@trusktr
We don't need to init if we're only testing marked. We probably don't…
9847f69 
… need to test marked either, as we assume that the marked library works as advertised in whichever way they tested it.
@vercel
Copy link

vercel bot commented Nov 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/b949nbmh9
✅ Preview: https://docsify-preview-git-trusktr-testing.docsify-core.vercel.app

@trusktr trusktr changed the title We don't need to init if we're only testing marked. We probably don't… trusktr testing Nov 1, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9847f69:

Sandbox Source
docsify-template Configuration

@jhildenbiddle
Copy link
Member

jhildenbiddle commented Nov 1, 2020

@trusktr FWIW, I don't think we need to test marked either. I only converted these tests from the old setup because I didn't want anyone to say "what happened to test X". I figured discussions about what tests we can get rid of could happen after the conversion.

@trusktr trusktr marked this pull request as draft November 1, 2020 23:15
@trusktr
Copy link
Member Author

trusktr commented Nov 1, 2020

Cool. Just testing anyway. The test didn't pass because importing marked directly does not include our custom additions.

@trusktr trusktr changed the title trusktr testing trusktr testing (IGNORE THIS) Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trusktr @jhildenbiddle