Use single best completion item for commands, options, and global options#1700
Draft
baronfel wants to merge 1 commit intodotnet:mainfrom
Draft
Use single best completion item for commands, options, and global options#1700baronfel wants to merge 1 commit intodotnet:mainfrom
baronfel wants to merge 1 commit intodotnet:mainfrom
Conversation
4e302af to
679c60d
Compare
baronfel
commented
Apr 7, 2022
| { | ||
| #if NET6_0_OR_GREATER | ||
| "" => aliases.MaxBy(a => a.Length), // find the longest alias | ||
| (string stem) => aliases.Where(a => a.Contains(stem, StringComparison.OrdinalIgnoreCase)).OrderByDescending(a => TokenDistances.GetLevensteinDistance(stem, a)).ThenByDescending(a => TokenDistances.GetStartsWithDistance(stem, a)).FirstOrDefault() |
Member
Author
There was a problem hiding this comment.
use alias.ContainsCaseInsensitive extension method instead here to remove TFM split
Consider using the first alias, or even Symbol.Name. This would give the app developer better control on which alias is preferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to make completions less noisy by using the most relevant available alias for each Subcommand or Option provided for completions. Currently, each of these adds all of its aliases to the pool of available completions, which is quite noisy and can be distracting to a user. Imagine a shell that displays descriptions for completions. Would you want completions at the top-level of the command to emit all 5 Help Option aliases on new rows, along with the same description? I don't think so.
Instead, we try to find the best alias for the Subcommand or Option. What 'best' means varies by context:
Left to do: