Remove unused isNewNativeImage parameter from NativeImage::Open#123775
Open
Remove unused isNewNativeImage parameter from NativeImage::Open#123775
Conversation
Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unused isNewNativeImage parameter from NativeImage::Open
Remove unused isNewNativeImage parameter from NativeImage::Open
Jan 29, 2026
This was referenced Jan 30, 2026
Open
Contributor
|
Tagging subscribers to this area: @agocke, @elinor-fung |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused isNewNativeImage out parameter from NativeImage::Open and cleans up its only call site, simplifying the native image loading path.
Changes:
- Updated
NativeImage::Opendeclaration innativeimage.hto drop the/* out */ bool *isNewNativeImageparameter. - Updated the implementation in
nativeimage.cppby removing all assignments to*isNewNativeImageand aligning the signature with the header. - Simplified
AssemblyBinder::LoadNativeImageinassemblybinder.cppby removing the unusedisNewNativeImagelocal and updating the call toNativeImage::Open.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/coreclr/vm/nativeimage.h |
Adjusts the NativeImage::Open API to remove the unused out parameter from the declaration. |
src/coreclr/vm/nativeimage.cpp |
Keeps the implementation in sync with the new signature and removes dead assignments to isNewNativeImage. |
src/coreclr/vm/assemblybinder.cpp |
Cleans up the only call site by removing the unused local and calling the simplified NativeImage::Open overload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
isNewNativeImageout parameter inNativeImage::Openwas being populated but never used by the sole caller inAssemblyBinder::LoadNativeImage.Changes
isNewNativeImageparameter from method signature innativeimage.handnativeimage.cpp*isNewNativeImagein the implementationassemblybinder.cppFiles Changed
src/coreclr/vm/nativeimage.hsrc/coreclr/vm/nativeimage.cppsrc/coreclr/vm/assemblybinder.cppcc @dotnet/appmodel @AaronRobinsonMSFT
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.