Fix XUnitWrapperGenerator handling of SkipOnCoreClrAttribute with no runtime test modes #123777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…runtime test modes Add check to skip tests if all RuntimeTestModes are skipped Fixes #105964
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a code-generation failure in XUnitWrapperGenerator when processing SkipOnCoreClrAttribute cases that result in no runtime-configuration/test-mode conditions, preventing invalid generated C# like if ().
Changes:
- Add a guard in
DecorateWithSkipOnCoreClrConfigurationto return an empty test set when no conditions are produced. - Avoid emitting
ConditionalTestwrappers with an empty condition expression.
src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated
Show resolved
Hide resolved
Updated skipped test platform and configuration handling to use 'Any' instead of 0 values as the default skip rules (matches the implementation in arcade)
jkoritzinsky
commented
Jan 30, 2026
src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
commented
Jan 30, 2026
src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
akoeplinger
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check to skip tests if all RuntimeTestModes are skipped
Fixes #105964