-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix BigInteger char parsing with Ukrainian culture NBSP handling (bidirectional) #123783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d8192f4
Initial plan
Copilot cef5ce0
Fix BigInteger UTF-8 parsing with Ukrainian culture and add tests
Copilot 31cf78e
Improve UTF-8 handling for space-replacing characters in MatchChars
Copilot eb6161f
Simplify Ukrainian culture tests - basic functionality working
Copilot 1066da7
Address code review feedback - update comments and tests
Copilot 71f03ee
Simplify to bidirectional space equivalence check (remove complex UTF…
Copilot ee8019f
Move Ukrainian culture tests into existing parse.cs file
Copilot 9ac8b78
Merge branch 'main' into copilot/fix-parse-test-uk-ua
stephentoub b1681ea
Remove UTF-8 parsing from tests (only test char/UTF-16 which is what …
Copilot a6b6bed
Optimize condition: check for space character before calling IsSpaceR…
Copilot d689f46
Make Ukrainian culture tests more defensive - only test when NBSP is …
Copilot f8dfecb
Improve test by using custom culture instead of uk-UA
Copilot 6824d53
Fix test: add actual spaces to testWithSpace string to test space equ…
Copilot c8c519e
Test all three MatchChars equivalence branches instead of unrelated A…
artl93 fb34cb1
Refactor to NormalizeSpaceReplacingChar helper for better readability
Copilot bfc2c9b
Apply suggestion from @stephentoub
stephentoub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.