Conversation
Contributor
Reviewer's GuideUpdates XML documentation comments and samples for several components (Input base, AutoFill, OTP input, Layout, Logout, Breadcrumb demo) and fixes a small bug in CssBuilder’s internal state flag, aligning Chinese/English docs and adding an attribute table demo. Class diagram for updated CssBuilder internal state handlingclassDiagram
class CssBuilder {
- StringBuilder _builder
- bool _hasContent
+ CssBuilder()
+ CssBuilder(string value)
+ static CssBuilder Default(string value)
+ static CssBuilder Default()
+ CssBuilder AddClass(string value)
+ CssBuilder AddClass(string value, bool condition)
+ CssBuilder AddClass(string value, Func<bool> condition)
+ CssBuilder AddClassFromAttributes(IDictionary additionalAttributes)
+ CssBuilder AddStyleFromAttributes(IDictionary additionalAttributes)
+ string Build()
}
Flow diagram for CssBuilder AddClass and Build behaviorflowchart TD
A[Create CssBuilder instance] --> B[Call AddClass with value]
B --> C{value is null or empty?}
C -- Yes --> D[Do nothing
_keep _hasContent unchanged_]
C -- No --> E{_hasContent is true?}
E -- Yes --> F[Append space to _builder]
E -- No --> G[Set _hasContent to true]
F --> H[Append value to _builder]
G --> H[Append value to _builder]
D --> I[Later call Build]
H --> I[Later call Build]
I --> J{_hasContent is true?}
J -- Yes --> K[Return _builder as string]
J -- No --> L[Return null]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves documentation quality across several BootstrapBlazor components, fixing mixed-language comments (English text embedded in Chinese XML doc comments) and correcting a longstanding field name typo.
Changes:
- Fixes typo in
CssBuilder.cs:_hasConentrenamed to_hasContentacross all usages - Updates XML doc comments from mixed Chinese/English to pure Chinese in
zhlang tags forBootstrapInputBase.cs,OtpInput.razor.cs,AutoFill.razor.cs,Layout.razor.cs, andLogout.razor.cs - Adds an
<AttributeTable>to theBreadcrumbs.razorsample page
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/BootstrapBlazor/Utils/CssBuilder.cs |
Fixes _hasConent typo to _hasContent throughout the class |
src/BootstrapBlazor/Components/Logout/Logout.razor.cs |
Fixes Chinese doc that was incorrectly in English |
src/BootstrapBlazor/Components/Layout/Layout.razor.cs |
Fixes Chinese doc that was a duplicate/mix of English |
src/BootstrapBlazor/Components/Input/OtpInput.razor.cs |
Translates mixed-language zh doc comments to pure Chinese |
src/BootstrapBlazor/Components/Input/BootstrapInputBase.cs |
Translates mixed-language zh doc comments to pure Chinese; also changes Type property docs from "Gets" to "Gets or sets" (correct, as the property has a public setter) |
src/BootstrapBlazor/Components/AutoFill/AutoFill.razor.cs |
Removes XML doc comments from private fields/methods, consistent with codebase convention |
src/BootstrapBlazor.Server/Components/Samples/Breadcrumbs.razor |
Adds <AttributeTable> for the Breadcrumb component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7741 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 750 750
Lines 33269 33269
Branches 4612 4612
=========================================
Hits 33269 33269
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7740
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve component documentation and samples while fixing a minor CSS builder bug.
Bug Fixes:
Enhancements:
Documentation: