s3: pass copy extra args during move and copy operations#549
Open
ai-m-kirk-51517 wants to merge 1 commit intodrivendataorg:masterfrom
Open
s3: pass copy extra args during move and copy operations#549ai-m-kirk-51517 wants to merge 1 commit intodrivendataorg:masterfrom
ai-m-kirk-51517 wants to merge 1 commit intodrivendataorg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #500 where
Copy*attributes (likeCopySourceSSECustomerKey) were not being passed to S3 copy operations during move/copy.I have introduced
boto3_copy_extra_argswhich usesS3Transfer.ALLOWED_COPY_ARGSto filter relevant extra arguments and ensured they are passed to thetarget.copycall.Checklist
_move_filenow uses the specific copy extra args.