Skip to content

replaced _gx_system_lock with GX_ENTER_CRITICAL#137

Closed
parsley wants to merge 2 commits intoeclipse-threadx:devfrom
parsley:fix_mutex
Closed

replaced _gx_system_lock with GX_ENTER_CRITICAL#137
parsley wants to merge 2 commits intoeclipse-threadx:devfrom
parsley:fix_mutex

Conversation

@parsley
Copy link

@parsley parsley commented Jan 29, 2026

replaced _gx_system_lock and _gx_system_unlock with GX_ENTER_CRITICAL and GX_EXIT_CRITICAL.

This change mainly effects gx_horizontal_list_total_columns_set.c and gx_vertical_list_total_rows_set.c.
All other changes are only in comments.

@fdesbiens
Copy link
Contributor

Thank you for this contribution, @parsley!

Before we can accept it, you need to sign the Eclipse Contributor Agreement (ECA). The purpose of the ECA is to provide a written record that you have agreed to provide your code and documentation contributions under the licenses used by the Eclipse ThreadX project. It also makes it clear that you are promising that what you are contributing to Eclipse is code you wrote, and you have the necessary rights to contribute it to our projects. And finally, it documents a commitment from you that your open source contributions will be permanently on the public record.

Signing the ECA requires an Eclipse Foundation account if you do not already have one. You can create one for free at https://accounts.eclipse.org.

Be sure to use the same email address when you register for the account that you intend to use on Git commit records. Also, please add your GitHub ID to your Eclipse account. This enables synchronisation between Eclipse-owned infrastructure and GitHub.

Here is the link to sign the ECA:
https://accounts.eclipse.org/user/login?destination=user/eca

@fdesbiens fdesbiens changed the base branch from master to dev February 5, 2026 20:42
@fdesbiens
Copy link
Contributor

@parsley Our ECA checker still cannot find a signed agreement matching your email and GitHub ID. Please correct this ASAP so I can merge this change and ship it next week in our Q1 2026 release.

@parsley
Copy link
Author

parsley commented Mar 3, 2026

Hi @fdesbiens
I'm sorry. I didn't pay enough attention to what git account I used. I meant to commit/push/PR with my private account (since this is my private contribution) but recognized too late, that I mixed accounts. That is the main reason for this delay.
Since I rarely use git I welcome any hints what's the best way to fix this. If I'm right I need to make each commit/push again with my own account?
Sorry for this hick up! I'd like to contribute even more changes once this is cleaned up.

@fdesbiens
Copy link
Contributor

No worries, @parsley.

Since you are not a Git guru, the easiest way would be to create new commits and a new PR using the appropriate account. You can close the old ones.

@parsley
Copy link
Author

parsley commented Mar 3, 2026

You are right, I did learn and read a lot about git but sadly rarely have the chance to use it, hence lacking actual experience.

At least I used the right github account and only missed to change git config user.name and user.email before I did my commits, right?.
Do I miss anything else?

I'll close my PRs and have another try.

@parsley parsley closed this Mar 3, 2026
@parsley parsley deleted the fix_mutex branch March 3, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants