replaced _gx_system_lock with GX_ENTER_CRITICAL#137
replaced _gx_system_lock with GX_ENTER_CRITICAL#137parsley wants to merge 2 commits intoeclipse-threadx:devfrom
Conversation
Merge changes ahead of the 202504 release
… and GX_EXIT_CRITICAL
|
Thank you for this contribution, @parsley! Before we can accept it, you need to sign the Eclipse Contributor Agreement (ECA). The purpose of the ECA is to provide a written record that you have agreed to provide your code and documentation contributions under the licenses used by the Eclipse ThreadX project. It also makes it clear that you are promising that what you are contributing to Eclipse is code you wrote, and you have the necessary rights to contribute it to our projects. And finally, it documents a commitment from you that your open source contributions will be permanently on the public record. Signing the ECA requires an Eclipse Foundation account if you do not already have one. You can create one for free at https://accounts.eclipse.org. Be sure to use the same email address when you register for the account that you intend to use on Git commit records. Also, please add your GitHub ID to your Eclipse account. This enables synchronisation between Eclipse-owned infrastructure and GitHub. Here is the link to sign the ECA: |
|
@parsley Our ECA checker still cannot find a signed agreement matching your email and GitHub ID. Please correct this ASAP so I can merge this change and ship it next week in our Q1 2026 release. |
|
Hi @fdesbiens |
|
No worries, @parsley. Since you are not a Git guru, the easiest way would be to create new commits and a new PR using the appropriate account. You can close the old ones. |
|
You are right, I did learn and read a lot about git but sadly rarely have the chance to use it, hence lacking actual experience. At least I used the right github account and only missed to change git config user.name and user.email before I did my commits, right?. I'll close my PRs and have another try. |
replaced
_gx_system_lockand_gx_system_unlockwithGX_ENTER_CRITICALandGX_EXIT_CRITICAL.This change mainly effects
gx_horizontal_list_total_columns_set.candgx_vertical_list_total_rows_set.c.All other changes are only in comments.