Revert "add code to support node 8"#1241
Open
mansona wants to merge 2 commits intoember-cli:masterfrom
Open
Conversation
kategengler
reviewed
Aug 10, 2023
src/get-start-and-end-commands.js
Outdated
|
|
||
| if (isCustomBlueprint || isGlimmer) { | ||
| args = [`ember-cli@${lastNode8Version}`, ...args]; | ||
| args = ['ember-cli', ...args]; |
Member
There was a problem hiding this comment.
I might do 'ember-cli@latest' here
Member
Author
There was a problem hiding this comment.
Yea I agree! that's what I did in my other PR that actually fixes the v2 addon blueprint: https://github.com/ember-cli/ember-cli-update/pull/1240/files#diff-b036a2bfff3e6c44af88056b383d9acaeb4f45c37efb5559d60ebec68250eb10L178
This reverts commit 13e645c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 13e645c.
This is related to the note I added in #1240, essentially we had code in there with the comment
// remove when node 8 is droppedand this PR just removes it.I don't really have the context to understand why this was added 🤔 any help or guidance would be appreciated 👍