Fix: AsyncTunnelHTTPConnection leaks connection on handshake failure #1056
+276
−166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1023.
When using an HTTP proxy with tunneling (HTTPS requests), if the
CONNECThandshake fails (e.g.RemoteProtocolError, timeouts, or TLS errors during the tunnel setup), the underlying network stream was not explicitly closed.This caused the connection to remain in the pool as "active" but dead. If
max_connectionsis set, this eventually leads to pool starvation where no new requests can be made.The Fix
AsyncTunnelHTTPConnection.handle_async_requestwith atry...exceptblock.await self._connection.aclose()if any exception occurs during the handshake or TLS upgrade steps.Verification
I verified this with a local reproduction script that simulates a proxy server accepting a connection and then immediately closing it (crashing the handshake).
Before the fix:
max_connections=1).After the fix: