Show how to set custom_tags for tracing#293
Open
adilhafeez wants to merge 5 commits intoenvoyproxy:mainfrom
Open
Show how to set custom_tags for tracing#293adilhafeez wants to merge 5 commits intoenvoyproxy:mainfrom
adilhafeez wants to merge 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adil Hafeez <adil.hafeez@gmail.com>
adilhafeez
force-pushed
the
adilhafeez/add_custom_tags
branch
from
1be6e85 to
c08a403
Compare
Signed-off-by: Adil Hafeez <adil.hafeez@gmail.com>
adilhafeez
changed the title
Contributor
Author
|
@phlax pls take a look |
adilhafeez
commented
Nov 15, 2024
Signed-off-by: Adil Hafeez <adil@katanemo.com>
phlax
reviewed
Nov 15, 2024
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
i think this needs a bit more documentation to show how the custom tags are used - and something in the verify.sh to ensure its working as expected
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Adil Hafeez <adil@katanemo.com>
phlax
reviewed
Jun 16, 2025
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
@adilhafeez i would like to land this but it really does need some explanation in the docs as to how to add tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.