Skip to content

Fix codecov upload condition in CI workflow #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etr merged 8 commits into from
Jan 31, 2026
Merged

Fix codecov upload condition in CI workflow #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5bd1367
Fix codecov upload condition in CI workflow
etr Jan 30, 2026
fcdede1
Replace deprecated Codecov bash uploader with official GitHub Action
etr Jan 31, 2026
e2dbaf7
Add gcovr step to generate coverage report before Codecov upload
etr Jan 31, 2026
fd6cd28
Add CODECOV_TOKEN for protected branch uploads
etr Jan 31, 2026
b0b0a05
Trigger CI to test Codecov upload with token
etr Jan 31, 2026
9b3305e
Add --root option to gcovr for correct source path mapping
etr Jan 31, 2026
1e2b2aa
Exclude test directory from coverage reports
etr Jan 31, 2026
4cfe7ac
Ignore tests
etr Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/verify-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,8 +665,16 @@ jobs:
sleep 5 && ab -n 1000000 -c 100 127.0.0.1:8080/plaintext
if: ${{ matrix.build-type == 'threads' }}

- name: Push code coverage data
- name: Generate coverage report
run: |
cd build ;
bash <(curl -s https://codecov.io/bash) ;
if: ${{ matrix.os-type == 'discard' && matrix.c-compiler == 'gcc' && matrix.debug == 'debug' && matrix.coverage == 'coverage' && success() }}
cd build
gcovr --root .. --exclude test/ --xml coverage.xml --xml-pretty
if: ${{ matrix.os-type == 'ubuntu' && matrix.c-compiler == 'gcc' && matrix.debug == 'debug' && matrix.coverage == 'coverage' && success() }}

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: build/coverage.xml
fail_ci_if_error: false
if: ${{ matrix.os-type == 'ubuntu' && matrix.c-compiler == 'gcc' && matrix.debug == 'debug' && matrix.coverage == 'coverage' && success() }}
3 changes: 3 additions & 0 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ comment:
layout: "reach,diff,flags,files,footer"
behavior: default
require_changes: no

ignore:
- "test"
Loading