Implement JS-esque StateBase.srcCharCodeAt#190
Implement JS-esque StateBase.srcCharCodeAt#190hukkin wants to merge 6 commits intoexecutablebooks:masterfrom
StateBase.srcCharCodeAt#190Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 96.17% 96.11% -0.07%
==========================================
Files 61 61
Lines 3267 3267
==========================================
- Hits 3142 3140 -2
- Misses 125 127 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Seeing that this PR only removes 4 instances of The downsides for rejecting are diverging slightly from upstream logic, and the chance that there's still some place in the code where |
Replaces use of
StateBase.srcCharCodewith the more JS-esqueStateBase.srcCharCodeAtthat can returnNone.I didn't remove
StateBase.srcCharCodefor ease of migration because mdit-py-plugins use it. But did deprecate it.Happy to hear what you think @chrisjsewell . Not sure if this is the solution or migration strategy you want, but it's something 😄
I haven't measured performance yet. We may want to do that if this is something we want to proceed with otherwise
EDIT: This PR is in response to discussion in #186