fix(compiler): reduce empty array without init val#911
Merged
antonmedv merged 1 commit intoexpr-lang:masterfrom Jan 22, 2026
Merged
fix(compiler): reduce empty array without init val#911antonmedv merged 1 commit intoexpr-lang:masterfrom
antonmedv merged 1 commit intoexpr-lang:masterfrom
Conversation
Add bounds check before accessing first element when reduce is called without an initial value. Previously this caused a panic on empty arrays. Now returns a clear error: "reduce of empty array with no initial value". Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
antonmedv
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fuzzing discovered a panic in #908 on an unrelated change. The full run logs can be found here but the gist of it:
This issue is triggered when
reduceis called on an empty array without an initial value (e.g.,reduce(9..0, # + #acc)). The compiler emits code that accessed the first element before checking if the array was empty.Changes
reducehas no initial value, throwing a descriptive error if the array is emptyFurther comments
The optimizer correctly skips optimization for reversed ranges (like 10..1) and delegates to runtime. This fix ensures the runtime handles empty arrays gracefully instead of panicking.