builtin: enforce MemoryBudget for split and splitAfter#938
Open
thesmartshadow wants to merge 1 commit intoexpr-lang:masterfrom
Open
builtin: enforce MemoryBudget for split and splitAfter#938thesmartshadow wants to merge 1 commit intoexpr-lang:masterfrom
thesmartshadow wants to merge 1 commit intoexpr-lang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a MemoryBudget bypass where allocation-heavy builtins compiled via
OpCall*were not accounted, allowing large heap allocations despite a smallvm.VM.MemoryBudget.What changed
splitandsplitAfterfromFunc→Safeso allocations are charged viaOpCallSafe+vm.memGrow.MemoryBudgetblocks largesplit/splitAfteroutputs.Why
split/splitAftercan produce very large slices from attacker-controlled input (common in rule engines / policy evaluators). With this change, those allocations are properly budgeted and will returnmemory budget exceededwhen the budget is too small.Tests
go test ./...TestMemoryBudget_SplitBuiltin,TestMemoryBudget_SplitAfterBuiltin