Skip to content

Comments

feat: review sidebar version switcher#2191

Closed
g-francesca wants to merge 85 commits intoredesignfrom
sidebar-version-switcher
Closed

feat: review sidebar version switcher#2191
g-francesca wants to merge 85 commits intoredesignfrom
sidebar-version-switcher

Conversation

@g-francesca
Copy link
Collaborator

WIP

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@netlify
Copy link

netlify bot commented Feb 20, 2026

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 95cd424
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/6998909f1c7ce10008cbf81e
😎 Deploy Preview https://deploy-preview-2191--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 3 from production)
Accessibility: 100 (🟢 up 13 from production)
Best Practices: 100 (no change from production)
SEO: 90 (🔴 down 4 from production)
PWA: 80 (🟢 up 50 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@ctcpip
Copy link
Member

ctcpip commented Feb 20, 2026

strong preference for reloading the correct page when switching versions; doing nothing feels like a bug... and I'd argue it IS a bug

this is also consistent with every other versioned docs interface that I have ever used

@crandmck
Copy link
Member

Strongly agree with @ctcpip

@bjohansebas
Copy link
Member

Okay, several people already said they prefer the current state. @g-francesca, feel free to close it.

@bjohansebas bjohansebas reopened this Feb 21, 2026
@g-francesca
Copy link
Collaborator Author

Thanks for the feedback! I'm closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants