Fix blocking animating non-layout props through commitUpdates after the View was synchronously animated#55340
Closed
coado wants to merge 1 commit intofacebook:mainfrom
Closed
Fix blocking animating non-layout props through commitUpdates after the View was synchronously animated#55340coado wants to merge 1 commit intofacebook:mainfrom
commitUpdates after the View was synchronously animated#55340coado wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
coado
changed the title
View was synchronously animatedcommitUpdates after the View was synchronously animated
coado
force-pushed
the
export-D91677971
branch
from
5d6ca3f to
1b3a3a6
Compare
coado
force-pushed
the
export-D91677971
branch
from
1b3a3a6 to
0d6a390
Compare
coado
force-pushed
the
export-D91677971
branch
from
0d6a390 to
e758e67
Compare
… the `View` was synchronously animated (facebook#55340) Summary: This diff fixes edge-case with animating non-layout props through `commitUpdates` path. The non-layout props are animated through the synchronous short-path, skipping yoga layout calculations. In `RCTMountingManager` the `propKeysManagerByAnimated` were set on updated props which are then checked for and blocked in the RCTViewComponentView's `updateProps` method (non-layout props might be applied through the layout path as we animate props in batch that may consists of both types of props). ## Changelog: [iOS][Fixed] - Fixed edge-case with animating non-layout props through the `commitUpdates` path. Reviewed By: zeyap, javache Differential Revision: D91677971
coado
force-pushed
the
export-D91677971
branch
from
e758e67 to
f7c0d7d
Compare
Collaborator
|
This pull request was successfully merged by @coado in 31f215a When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 31f215a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff fixes edge-case with animating non-layout props through
commitUpdatespath.The non-layout props are animated through the synchronous short-path, skipping yoga layout calculations. In
RCTMountingManagerthepropKeysManagerByAnimatedwere set on updated props which are then checked for and blocked in the RCTViewComponentView'supdatePropsmethod (non-layout props might be applied through the layout path as we animate props in batch that may consists of both types of props).Changelog:
[iOS][Fixed] - Fixed edge-case with animating non-layout props through the
commitUpdatespath.Differential Revision: D91677971
before.mov
after.mov