Skip to content

Comments

fix: Add nkf and base64 to Gemfile for Ruby 3.4 compatibility#55346

Closed
kimchi-developer wants to merge 1 commit intofacebook:mainfrom
kimchi-developer:fix/ruby-3.4-compatibility
Closed

fix: Add nkf and base64 to Gemfile for Ruby 3.4 compatibility#55346
kimchi-developer wants to merge 1 commit intofacebook:mainfrom
kimchi-developer:fix/ruby-3.4-compatibility

Conversation

@kimchi-developer
Copy link
Contributor

Ruby 3.4 removed 'kconv' (which requires 'nkf') and 'base64' from the standard library. This commit adds them to the Gemfiles to fix 'pod install' failures on Ruby 3.4 environments.

Ruby 3.4 removed 'kconv' (which requires 'nkf') and 'base64' from the standard library. This commit adds them to the Gemfiles to fix 'pod install' failures on Ruby 3.4 environments.
@meta-cla
Copy link

meta-cla bot commented Jan 29, 2026

Hi @kimchi-developer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Jan 29, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2026
@meta-cla
Copy link

meta-cla bot commented Jan 29, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 29, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 3, 2026

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D92147798.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync bot closed this in 51c9658 Feb 3, 2026
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 3, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 3, 2026

@cipolleschi merged this pull request in 51c9658.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @kimchi-developer in 51c9658

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants