Fix lint issues in CatalystInstanceImpl.java#55372
Closed
mdvacca wants to merge 2 commits intofacebook:mainfrom
Closed
Fix lint issues in CatalystInstanceImpl.java#55372mdvacca wants to merge 2 commits intofacebook:mainfrom
mdvacca wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
mdvacca
force-pushed
the
export-D91795470
branch
from
560d66a to
79800fa
Compare
…essage (facebook#55359) Summary: Fixed ReflectionMethodUse lint error in AnimationDriver.kt. Replaced `javaClass.simpleName` with a hardcoded string to avoid reflection which can cause issues with Redex obfuscation in production builds. changelog: [internal] internal Reviewed By: javache Differential Revision: D91736698
Summary: Fixed two lint warnings in CatalystInstanceImpl.java: - NotInvokedPrivateMethod: Removed unused native method `unregisterFromInspector()` - DeadVariable: Removed unused variable `wasIdle` while keeping the side effect of `mPendingJSCalls.getAndSet(0)` changelog: [internal] internal Reviewed By: javache Differential Revision: D91795470
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 3, 2026
Summary: Fixed two lint warnings in CatalystInstanceImpl.java: - NotInvokedPrivateMethod: Removed unused native method `unregisterFromInspector()` - DeadVariable: Removed unused variable `wasIdle` while keeping the side effect of `mPendingJSCalls.getAndSet(0)` changelog: [internal] internal Reviewed By: javache Differential Revision: D91795470
mdvacca
force-pushed
the
export-D91795470
branch
from
79800fa to
c229435
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 3, 2026
Summary: Fixed two lint warnings in CatalystInstanceImpl.java: - NotInvokedPrivateMethod: Removed unused native method `unregisterFromInspector()` - DeadVariable: Removed unused variable `wasIdle` while keeping the side effect of `mPendingJSCalls.getAndSet(0)` changelog: [internal] internal Reviewed By: javache Differential Revision: D91795470
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 4, 2026
Summary: Fixed two lint warnings in CatalystInstanceImpl.java: - NotInvokedPrivateMethod: Removed unused native method `unregisterFromInspector()` - DeadVariable: Removed unused variable `wasIdle` while keeping the side effect of `mPendingJSCalls.getAndSet(0)` changelog: [internal] internal Reviewed By: javache Differential Revision: D91795470
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 4, 2026
Summary: Fixed two lint warnings in CatalystInstanceImpl.java: - NotInvokedPrivateMethod: Removed unused native method `unregisterFromInspector()` - DeadVariable: Removed unused variable `wasIdle` while keeping the side effect of `mPendingJSCalls.getAndSet(0)` changelog: [internal] internal Reviewed By: javache Differential Revision: D91795470
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 4, 2026
Summary: Fixed two lint warnings in CatalystInstanceImpl.java: - NotInvokedPrivateMethod: Removed unused native method `unregisterFromInspector()` - DeadVariable: Removed unused variable `wasIdle` while keeping the side effect of `mPendingJSCalls.getAndSet(0)` changelog: [internal] internal Reviewed By: javache Differential Revision: D91795470
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 4, 2026
Summary: Fixed two lint warnings in CatalystInstanceImpl.java: - NotInvokedPrivateMethod: Removed unused native method `unregisterFromInspector()` - DeadVariable: Removed unused variable `wasIdle` while keeping the side effect of `mPendingJSCalls.getAndSet(0)` changelog: [internal] internal Reviewed By: javache Differential Revision: D91795470
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 4, 2026
Summary: Fixed two lint warnings in CatalystInstanceImpl.java: - NotInvokedPrivateMethod: Removed unused native method `unregisterFromInspector()` - DeadVariable: Removed unused variable `wasIdle` while keeping the side effect of `mPendingJSCalls.getAndSet(0)` changelog: [internal] internal Reviewed By: javache Differential Revision: D91795470
Collaborator
|
This pull request was successfully merged by @mdvacca in 28f8098 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 28f8098. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed two lint warnings in CatalystInstanceImpl.java:
unregisterFromInspector()wasIdlewhile keeping the side effect ofmPendingJSCalls.getAndSet(0)changelog: [internal] internal
Reviewed By: javache
Differential Revision: D91795470