Fix lint issues in ReactInstanceManager.java#55375
Closed
mdvacca wants to merge 6 commits intofacebook:mainfrom
Closed
Fix lint issues in ReactInstanceManager.java#55375mdvacca wants to merge 6 commits intofacebook:mainfrom
mdvacca wants to merge 6 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
…essage (facebook#55359) Summary: Fixed ReflectionMethodUse lint error in AnimationDriver.kt. Replaced `javaClass.simpleName` with a hardcoded string to avoid reflection which can cause issues with Redex obfuscation in production builds. changelog: [internal] internal Reviewed By: javache Differential Revision: D91736698
Summary: Fixed two lint warnings in CatalystInstanceImpl.java: - NotInvokedPrivateMethod: Removed unused native method `unregisterFromInspector()` - DeadVariable: Removed unused variable `wasIdle` while keeping the side effect of `mPendingJSCalls.getAndSet(0)` changelog: [internal] internal Reviewed By: javache Differential Revision: D91795470
…5373) Summary: Fixed FieldsBelowInit lint warnings by reordering declarations to appear before init blocks: - Moved `signature` property above the class's init block - Moved all ARGUMENT_EXTRACTOR_* fields and DEBUG field above the companion object's init block In Kotlin, fields should be declared before init blocks to ensure proper initialization order. changelog: [internal] internal Reviewed By: javache Differential Revision: D91795927
Summary: Rewrote the equals() method to avoid false-positive SelfComparison lint errors, using the same pattern as JavaOnlyArray.kt fix. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91802716
Summary: Moved TAG field above the companion object's init block to fix lint warning about fields declared below init blocks. changelog: [internal] internal Reviewed By: javache Differential Revision: D91814236
Summary: Fixed multiple lint errors in ReactInstanceManager.java: - NonStaticNestedClass: Made ReactContextInitParams class static since it doesn't need to access instance members - ClownyBooleanExpression: Removed unnecessary `if (true)` wrapper around throw statement - DeadVariable: Removed unused devSettings variable - EmptyCatchBlock: Added explanatory comment for InterruptedException handling changelog: [internal] internal Reviewed By: javache Differential Revision: D91814708
mdvacca
force-pushed
the
export-D91814708
branch
from
46d9349 to
8876f3d
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 4, 2026
Summary: Fixed multiple lint errors in ReactInstanceManager.java: - NonStaticNestedClass: Made ReactContextInitParams class static since it doesn't need to access instance members - ClownyBooleanExpression: Removed unnecessary `if (true)` wrapper around throw statement - DeadVariable: Removed unused devSettings variable - EmptyCatchBlock: Added explanatory comment for InterruptedException handling changelog: [internal] internal Reviewed By: javache Differential Revision: D91814708
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 4, 2026
Summary: Fixed multiple lint errors in ReactInstanceManager.java: - NonStaticNestedClass: Made ReactContextInitParams class static since it doesn't need to access instance members - ClownyBooleanExpression: Removed unnecessary `if (true)` wrapper around throw statement - DeadVariable: Removed unused devSettings variable - EmptyCatchBlock: Added explanatory comment for InterruptedException handling changelog: [internal] internal Reviewed By: javache Differential Revision: D91814708
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 4, 2026
Summary: Fixed multiple lint errors in ReactInstanceManager.java: - NonStaticNestedClass: Made ReactContextInitParams class static since it doesn't need to access instance members - ClownyBooleanExpression: Removed unnecessary `if (true)` wrapper around throw statement - DeadVariable: Removed unused devSettings variable - EmptyCatchBlock: Added explanatory comment for InterruptedException handling changelog: [internal] internal Reviewed By: javache Differential Revision: D91814708
|
This pull request has been merged in b335121. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed multiple lint errors in ReactInstanceManager.java:
if (true)wrapper around throw statementchangelog: [internal] internal
Reviewed By: javache
Differential Revision: D91814708