Skip to content

Comments

Added missing tests for onHoverOut in Pressability#55378

Closed
chicio wants to merge 1 commit intofacebook:mainfrom
chicio:on_hover_out_tests
Closed

Added missing tests for onHoverOut in Pressability#55378
chicio wants to merge 1 commit intofacebook:mainfrom
chicio:on_hover_out_tests

Conversation

@chicio
Copy link
Contributor

@chicio chicio commented Jan 30, 2026

Summary:

This PR adds the missing tests for the Pressability class, specifically for the onHoverOut property.
The tests simulate interactions similar to the existing onHoverIn tests, triggering onMouseEnter followed by onMouseLeave to verify that onHoverOut is called correctly.

Changelog:

[General] [Added] - Added tests for Pressability onHoverOut property

Test Plan:

  • Ran the full React Native test suite to ensure all tests pass.
  • Verified that the tests fail if the production code for onHoverOut is removed, confirming their effectiveness.

@meta-cla
Copy link

meta-cla bot commented Jan 30, 2026

Hi @chicio!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Jan 30, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2026
@meta-cla
Copy link

meta-cla bot commented Jan 30, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 30, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 31, 2026

@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D91951355.

@chicio
Copy link
Contributor Author

chicio commented Feb 2, 2026

Hi @Abbondanzo, thanks for importing my PR. Is there anything else i should do on my side to start the review process? Thanks for the help 🙏

PS i'm asking because this is my first contribution and I hope I didn't miss anything. Thanks again for the help.

@Abbondanzo
Copy link
Contributor

Hi @Abbondanzo, thanks for importing my PR. Is there anything else i should do on my side to start the review process? Thanks for the help 🙏

PS i'm asking because this is my first contribution and I hope I didn't miss anything. Thanks again for the help.

Hi @chicio, nothing else ya need to do on your part! I've imported the change and it's just awaiting a review internally, I'll ping a few people tomorrow morning if London doesn't get to it first. Thanks for the contribution!

@meta-codesync meta-codesync bot closed this in de59948 Feb 3, 2026
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 3, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 3, 2026

@Abbondanzo merged this pull request in de59948.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @chicio in de59948

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants