Added missing tests for onHoverOut in Pressability#55378
Added missing tests for onHoverOut in Pressability#55378chicio wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @chicio! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D91951355. |
|
Hi @Abbondanzo, thanks for importing my PR. Is there anything else i should do on my side to start the review process? Thanks for the help 🙏 PS i'm asking because this is my first contribution and I hope I didn't miss anything. Thanks again for the help. |
Hi @chicio, nothing else ya need to do on your part! I've imported the change and it's just awaiting a review internally, I'll ping a few people tomorrow morning if London doesn't get to it first. Thanks for the contribution! |
|
@Abbondanzo merged this pull request in de59948. |
|
This pull request was successfully merged by @chicio in de59948 When will my fix make it into a release? | How to file a pick request? |
Summary:
This PR adds the missing tests for the
Pressabilityclass, specifically for theonHoverOutproperty.The tests simulate interactions similar to the existing
onHoverIntests, triggeringonMouseEnterfollowed byonMouseLeaveto verify thatonHoverOutis called correctly.Changelog:
[General] [Added] - Added tests for
PressabilityonHoverOutpropertyTest Plan:
onHoverOutis removed, confirming their effectiveness.